Skip to content

Add procedure for converting external Swift storage nodes - #1342

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
cschwede:swift-conversion
Apr 7, 2026
Merged

Add procedure for converting external Swift storage nodes#1342
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
cschwede:swift-conversion

Conversation

@cschwede

@cschwede cschwede commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Adds documentation for converting existing TripleO-managed Swift storage nodes post-adoption without data migration.

There are two ways to adopt existing Swift storage nodes:

  1. Migrate data to PVs (or dataplane nodes), which is required if Swift storage was deployed on previous controller nodes
  2. Convert existing TripleO/Director-managed nodes to dataplane nodes, which should be used for any former external ObjectStorage node to avoid moving huge amounts of data.

This commit adds documentation for the second option; the first one already exists.

@softwarefactory-project-zuul

Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/data-plane-adoption for 1342,8716ee680e590e4a606c865cb6d677c55767d612

@softwarefactory-project-zuul

Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/data-plane-adoption for 1342,0bdade46976b1d2225981766ae1b80aa8974c191

@klgill klgill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cschwede. I have a few style changes that need to be implemented.

Comment thread docs_user/assemblies/assembly_migrating-the-object-storage-service.adoc Outdated
Comment thread docs_user/assemblies/assembly_migrating-the-object-storage-service.adoc Outdated
Comment thread docs_user/modules/proc_adopting-the-object-storage-service.adoc Outdated
Comment thread docs_user/modules/proc_adopting-the-object-storage-service.adoc Outdated
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc Outdated
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc Outdated
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc Outdated
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc Outdated
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc Outdated
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc Outdated
@cschwede

cschwede commented Apr 4, 2026

Copy link
Copy Markdown
Contributor Author

Hi @cschwede. I have a few style changes that need to be implemented.

Thanks @klgill for your review! I applied your changes and squashed them into the first commit. I added a second commit with a few additions/fixes, can you have a look at that one too please? I'll squash the commit as well once you reviewed these changes.

@klgill klgill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cschwede I have a few more minor changes.

Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc Outdated
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc Outdated
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc Outdated
Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc Outdated
@cschwede
cschwede force-pushed the swift-conversion branch 2 times, most recently from 59c7186 to df52575 Compare April 7, 2026 08:20
@cschwede

cschwede commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

@cschwede I have a few more minor changes.

Thanks @klgill, applied all suggestions and squashed them into the main commit.

Changes from yesterdays commit: https://github.com/openstack-k8s-operators/data-plane-adoption/compare/b7818a8d98e0dfe8232b6b869f2201ab455c4117..df52575eed95d484bfcf6bf22e861e6085303a82

Comment thread docs_user/modules/proc_converting-object-storage-nodes.adoc Outdated

@klgill klgill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor formatting change. One of the notes is not rendering properly in the preview.

@cschwede

cschwede commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

I have one minor formatting change. One of the notes is not rendering properly in the preview.

Thanks, I just committed & squashed the change.

@klgill

klgill commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

@cschwede My latest suggestion didn't work either. I'll need to look at it on my own after this is merged.
Is this PR intended for FR6? If so, can you provide the link to the feature associated with this PR?

@cschwede

cschwede commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

@cschwede My latest suggestion didn't work either. I'll need to look at it on my own after this is merged. Is this PR intended for FR6? If so, can you provide the link to the feature associated with this PR?

@klgill Yes, FR6 - this is the feature: OSPRH-23099

Adds documentation for converting existing TripleO-managed Swift storage
nodes post-adoption without data migration.

There are two ways to adopt existing Swift storage nodes:
1. Migrate data to PVs (or dataplane nodes), which is required if Swift
   storage was deployed on previous controller nodes
2. Convert existing TripleO/Director-managed nodes to dataplane nodes,
   which should be used for any former external ObjectStorage node to
   avoid moving huge amounts of data.

This commit adds documentation for the second option; the first one
already exists.

JIRA: OSPRH-23099

Signed-off-by: Christian Schwede <cschwede@redhat.com>
Co-authored-by: Katie Gilligan <kgilliga@redhat.com>
@cschwede

cschwede commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

@cschwede My latest suggestion didn't work either. I'll need to look at it on my own after this is merged.

@klgill I think the issue was the intendation: https://github.com/openstack-k8s-operators/data-plane-adoption/compare/dedf9bbcc91a531915e172da698cd74a6cb12886..9fdeaabd9ca139bddd841985e7ee29534551ecfa

@klgill

klgill commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

@cschwede My latest suggestion didn't work either. I'll need to look at it on my own after this is merged.

@klgill I think the issue was the intendation: https://github.com/openstack-k8s-operators/data-plane-adoption/compare/dedf9bbcc91a531915e172da698cd74a6cb12886..9fdeaabd9ca139bddd841985e7ee29534551ecfa

Yes, that looks better!

@klgill klgill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Apr 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit bf6e42f into openstack-k8s-operators:main Apr 7, 2026
6 checks passed
@cschwede
cschwede deleted the swift-conversion branch April 7, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants